chore: Enable nullable annotations on BenchmarkDotNet project#3003
Merged
timcassell merged 3 commits intodotnet:masterfrom Feb 17, 2026
Merged
chore: Enable nullable annotations on BenchmarkDotNet project#3003timcassell merged 3 commits intodotnet:masterfrom
timcassell merged 3 commits intodotnet:masterfrom
Conversation
filzrev
force-pushed
the
chore-enable-nullable-9
branch
2 times, most recently
from
3bc5d24 to
b1e57f6
Compare
filzrev
commented
Feb 12, 2026
| public static string EnsureNotNull(this string? value) | ||
| { | ||
| return value ?? ""; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This helper method is used for [PublicAPI] related parameter.
When caller is not nullable aware. string type parameter can be null.
filzrev
commented
Feb 12, 2026
| RepresentativeBenchmarkCase = default!; | ||
| Benchmarks = []; | ||
| ProgramName = default!; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
These properties are not accessed when using BuildPartition.Empty
filzrev
commented
Feb 15, 2026
filzrev
force-pushed
the
chore-enable-nullable-9
branch
from
f622096 to
3f45451
Compare
filzrev
commented
Feb 15, 2026
| Descriptor = descriptor; | ||
| Job = job; | ||
| Parameters = parameters; | ||
| Parameters = parameters ?? ParameterInstances.Empty; |
Contributor
Author
There was a problem hiding this comment.
Replace null to EmptyParameterInstances.
To support existing non-null aware test projects.
timcassell
reviewed
Feb 16, 2026
src/BenchmarkDotNet/Detectors/Cpu/Windows/PowershellWmiCpuDetector.cs
Outdated
Show resolved
Hide resolved
filzrev
force-pushed
the
chore-enable-nullable-9
branch
from
5d940d1 to
5df6d98
Compare
Collaborator
|
Need to fix merge conflicts. |
filzrev
force-pushed
the
chore-enable-nullable-9
branch
from
5df6d98 to
84f29cf
Compare
timcassell
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix a part of issue #2815
By enabling #nullable enable and fix nullable errors.